Further re-work trim_react_native
#100
Merged
+13
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e7f85c6.
jhugman
force-pushed
the
jhugman/redo-trim-react-native
branch
from
9c29b56 to
d470a66
Compare
jhugman
changed the title
trim_react_native
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #98
Closes #44.
#98 did not seem to fix them problem, so reverting, and cherry-picking 47878b1 .
There are two extra things in #98: ordering the modules in a consistent manner so that the generated turbo-modules can be checked in to VCS, and returning
truein theinstallRustCratemethod.